Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

Jan Grulich grulja at
Sat May 11 20:47:41 BST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated May 11, 2013, 7:47 p.m.)

Review request for KDE Runtime and Casian Andrei.


This patch fixes a problem in Phonon KCM which is always set as changed when using PulseAudio. I made two changes. The first change is renaming of ready() signal from AudioSetup class to pulseAudioReady() which is connected to slot in KCM which sets PulseAudio to enabled in Phonon::DevicePreference. The second change is a new signal emitted when GUI is initialized and only when pulseAudioReady() signal was emitted before. This signal is connected to slot in KCM which inserts this widget to KCM and connects changed() signal to KCM changed() slot.


  phonon/kcm/audiosetup.h 4887efe 
  phonon/kcm/audiosetup.cpp 35dc4ca 
  phonon/kcm/main.h 277adfe 
  phonon/kcm/main.cpp 5d75cba 




Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list