Review Request 110083: Make kdepim libs optional dependency for libkfbapi
Martin Klapetek
martin.klapetek at gmail.com
Fri May 10 15:41:13 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110083/#review32318
-----------------------------------------------------------
CMakeLists.txt
<http://git.reviewboard.kde.org/r/110083/#comment24041>
Apparently installing LibKFbAPI-KDEPIMConfig.cmake in $LIB.../cmake/LibKFbAPI makes KDEPIM-Runtime not able to find it. Is there a way or do I need to install it to $LIB.../cmake/LibKFbAPI-KDEPIM/ ?
- Martin Klapetek
On May 10, 2013, 10:32 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110083/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 10:32 a.m.)
>
>
> Review request for kdelibs and KDEPIM-Libraries.
>
>
> Description
> -------
>
> kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.
>
>
> Diffs
> -----
>
> CMakeLists.txt 5aefdcf
> LibKFbAPI-KDEPIM.pc.in PRE-CREATION
> LibKFbAPI-KDEPIMConfig.cmake.in PRE-CREATION
> LibKFbAPI.pc.in af537d1
> libkfbapi/CMakeLists.txt dac62bc
> libkfbapi/commentinfo.h e5578c7
> libkfbapi/kdepim-utils.h PRE-CREATION
> libkfbapi/kdepim-utils.cpp PRE-CREATION
> libkfbapi/likeinfo.h e06052e
> libkfbapi/noteinfo.h 2492db1
> libkfbapi/noteinfo.cpp 154593d
> libkfbapi/notificationinfo.h a882694
> libkfbapi/userinfo.h ac22a7e
> libkfbapi/userinfo.cpp 26c64da
> libkfbapi/userinfoparser_p.h 0189a17
>
> Diff: http://git.reviewboard.kde.org/r/110083/diff/
>
>
> Testing
> -------
>
> Builds correctly here in both cases
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130510/70f0ab38/attachment.htm>
More information about the kde-core-devel
mailing list