Review Request 110328: Add config option to silently create initial password-less wallet

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110328/
-----------------------------------------------------------

(Updated May 6, 2013, 5:25 p.m.)


Review request for KDE Runtime and Harald Sitter.


Changes
-------

Use QLatin1String as suggested by Daniel Nicoletti.

QString::clear() doesn't turn a null QString into an empty QString after all.


Description
-------

This patch adds a UI-less config option to kwalletd that makes it create the initial local wallet silently with an empty password instead of prompting the user to enter one.

It's a change desired by downstream consumers Kubuntu and Netrunner, and perhaps others, and recreates a modification they used to carry for KDE 3. Their goal is to make KWallet mostly invisible to the user during routine operations, but still have users benefit from encrypted password storage behind the scenes.

As such the config option is intended to be set by distributions. The new behavior is disabled by default.

In the interest of keeping the delta between upstream and downstream as small as possible I'd say it makes sense to pick this up.


Diffs (updated)
-----

  kwalletd/kwalletd.h e8e74c3 
  kwalletd/kwalletd.cpp fa9fc11 

Diff: http://git.reviewboard.kde.org/r/110328/diff/


Testing
-------

Test package for Kubuntu by Harald Sitter, operation verified at runtime.


Thanks,

Eike Hein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130506/431cb660/attachment.htm>