Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

> On May 5, 2013, 11:01 a.m., Oswald Buddenhagen wrote:
> > kdm/kfrontend/genkdmconf.c, line 2112
> > <http://git.reviewboard.kde.org/r/110315/diff/3/?file=142251#file142251line2112>
> >
> >     i wonder whether this condition is actually useful. i originally added it because some *BSDs (iirc) had an incompatible adduser command. the situation may be entirely different for useradd.

I guess that we could rely on the fact that if useradd is found, the command would work in the same way for all distro's.  I will update the patch and just leave the check for useradd


- Raymond


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32063
-----------------------------------------------------------


On May 5, 2013, 10:53 a.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> -----------------------------------------------------------
> 
> (Updated May 5, 2013, 10:53 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and utilizes the correct tools to create the kdm user and group. This would fix an very old situation where at this moment only debian installations were recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -----
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> -------
> 
> Testing has been done on a couple of openSUSE systems and here the user and group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130505/95411e3e/attachment.htm>