Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

> On May 5, 2013, 10:09 a.m., Oswald Buddenhagen wrote:
> > useradd also exists on debian ("useradd is a low level utility for adding users. On Debian, administrators should usually use adduser(8) instead."), so in principle the paths can be unified.
> > 
> > however, when i was trying to implement this a decade or so ago, useradd was apparently requiring the caller to provide a UID, at which point i simply gave up. did i look wrong? or is this feature a semi-new addition?

According to the useradd man-page on openSUSE: 

       -r, --system
           Create a system account.

           System users will be created with no aging information in /etc/shadow, and their numeric identifiers are chosen in the
           SYS_UID_MIN-SYS_UID_MAX range, defined in /etc/login.defs, instead of UID_MIN-UID_MAX (and their GID counterparts for the creation of
           groups).

       -u, --uid UID
           The numerical value of the user's ID. This value must be unique, unless the -o option is used. The value must be non-negative. The
           default is to use the smallest ID value greater than or equal to UID_MIN and greater than every other user.

So if UID is not given, then it will be determined through the default (as indicated). 

I am also not sure if debian and openSUSE have the same version of useradd, so that the two could be merged in a single statement.  If you are running debian, then please send me the man page for useradd and I will update the patch with a unified approach. 


- Raymond


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32057
-----------------------------------------------------------


On May 5, 2013, 8:04 a.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> -----------------------------------------------------------
> 
> (Updated May 5, 2013, 8:04 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and utilizes the correct tools to create the kdm user and group. This would fix an very old situation where at this moment only debian installations were recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -----
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> -------
> 
> Testing has been done on a couple of openSUSE systems and here the user and group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130505/8ea83b39/attachment.htm>