Review Request 110083: Make kdepim libs optional dependency for libkfbapi

Martin Klapetek martin.klapetek at gmail.com
Sat May 4 10:34:48 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110083/
-----------------------------------------------------------

(Updated May 4, 2013, 9:34 a.m.)


Review request for kdelibs and KDEPIM-Libraries.


Changes
-------

Moved invalidTimezone constant to userinfo.h, so it can be reused


Description
-------

kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.


Diffs (updated)
-----

  LibKFbAPI-KDEPIMConfig.cmake.in PRE-CREATION 
  CMakeLists.txt 5aefdcf 
  LibKFbAPI-KDEPIM.pc.in PRE-CREATION 
  LibKFbAPI.pc.in af537d1 
  libkfbapi/CMakeLists.txt dac62bc 
  libkfbapi/commentinfo.h e5578c7 
  libkfbapi/kdepim-utils.h PRE-CREATION 
  libkfbapi/kdepim-utils.cpp PRE-CREATION 
  libkfbapi/likeinfo.h e06052e 
  libkfbapi/noteinfo.h 2492db1 
  libkfbapi/noteinfo.cpp 154593d 
  libkfbapi/notificationinfo.h a882694 
  libkfbapi/userinfo.h ac22a7e 
  libkfbapi/userinfo.cpp 26c64da 
  libkfbapi/userinfoparser_p.h 0189a17 

Diff: http://git.reviewboard.kde.org/r/110083/diff/


Testing
-------

Builds correctly here in both cases


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130504/bcd2a0c2/attachment.htm>


More information about the kde-core-devel mailing list