Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to "" )

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110118/#review31957
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On April 21, 2013, 6:18 p.m., Ömer Fadıl Usta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110118/
> -----------------------------------------------------------
> 
> (Updated April 21, 2013, 6:18 p.m.)
> 
> 
> Review request for kde-workspace, Aaron J. Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> plasma-desktop(7470)/libplasma Plasma::PackageStructure::setPath: "/home/usta/kde/inst/master/share/apps/plasma/packages/org.kde.desktop.activitymanager//org.kde.desktop.activitymanager" invalid, basePath is ""
> 
> it resets basePath due to double pluginname at the end of path.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/activitymanager/activitymanager.cpp 2ecb30d 
> 
> Diff: http://git.reviewboard.kde.org/r/110118/diff/
> 
> 
> Testing
> -------
> 
> After this patch that warning about invalid path is gone. I have checked that package->path() returning correct address now.
> 
> 
> Thanks,
> 
> Ömer Fadıl Usta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130503/690024f3/attachment.htm>