Review Request 110083: Make kdepim libs optional dependency for libkfbapi

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110083/
-----------------------------------------------------------

(Updated May 3, 2013, 9:41 a.m.)


Review request for kdelibs and KDEPIM-Libraries.


Changes
-------

 * Change WITH_KDEPIM_LIBS to WITH_KDEPIMLIBS
 * Forward declare classes
 * Add comment for invalid timezone constant


Description
-------

kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.


Diffs (updated)
-----

  CMakeLists.txt 5aefdcf 
  LibKFbAPI-KDEPIM.pc.in PRE-CREATION 
  LibKFbAPI-KDEPIMConfig.cmake.in PRE-CREATION 
  LibKFbAPI.pc.in af537d1 
  libkfbapi/CMakeLists.txt dac62bc 
  libkfbapi/commentinfo.h e5578c7 
  libkfbapi/kdepim-utils.h PRE-CREATION 
  libkfbapi/kdepim-utils.cpp PRE-CREATION 
  libkfbapi/likeinfo.h e06052e 
  libkfbapi/noteinfo.h 2492db1 
  libkfbapi/noteinfo.cpp 154593d 
  libkfbapi/notificationinfo.h a882694 
  libkfbapi/userinfo.h ac22a7e 
  libkfbapi/userinfo.cpp 26c64da 
  libkfbapi/userinfoparser_p.h 0189a17 

Diff: http://git.reviewboard.kde.org/r/110083/diff/


Testing
-------

Builds correctly here in both cases


Thanks,

Martin Klapetek

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/