Review Request 110083: Make kdepim libs optional dependency for libkfbapi

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110083/#review31926
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/110083/#comment23805>

    I would change that to WITH_KDEPIMLIBS, i.e. without underscore between KDEPIM and LIBS.
    For me KDEPIM_LIBS suggests libraries from module kdepim, while this is about libraries from kdepimlibs



libkfbapi/kdepim-utils.h
<http://git.reviewboard.kde.org/r/110083/#comment23806>

    I think you could forward declare Addressee here



libkfbapi/kdepim-utils.h
<http://git.reviewboard.kde.org/r/110083/#comment23807>

    those two most likely as well



libkfbapi/kdepim-utils.cpp
<http://git.reviewboard.kde.org/r/110083/#comment23808>

    how do you arrive at this value? is this documented somewhere?


- Kevin Krammer


On April 29, 2013, 11:18 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110083/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 11:18 a.m.)
> 
> 
> Review request for kdelibs and KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5aefdcf 
>   LibKFbAPI-KDEPIM.pc.in PRE-CREATION 
>   LibKFbAPI-KDEPIMConfig.cmake.in PRE-CREATION 
>   LibKFbAPI.pc.in af537d1 
>   libkfbapi/CMakeLists.txt dac62bc 
>   libkfbapi/commentinfo.h e5578c7 
>   libkfbapi/kdepim-utils.h PRE-CREATION 
>   libkfbapi/kdepim-utils.cpp PRE-CREATION 
>   libkfbapi/likeinfo.h e06052e 
>   libkfbapi/noteinfo.h 2492db1 
>   libkfbapi/noteinfo.cpp 154593d 
>   libkfbapi/notificationinfo.h a882694 
>   libkfbapi/userinfo.h ac22a7e 
>   libkfbapi/userinfo.cpp 26c64da 
>   libkfbapi/userinfoparser_p.h 0189a17 
> 
> Diff: http://git.reviewboard.kde.org/r/110083/diff/
> 
> 
> Testing
> -------
> 
> Builds correctly here in both cases
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130503/17d1ee1e/attachment.htm>