libs/kworkspace/kdisplaymanager.cpp mess

Martin Briza mbriza at
Thu May 2 15:00:59 BST 2013

On Thu, 02 May 2013 13:12:55 +0200, Martin Briza <mbriza at> wrote:
> On Tue, 30 Apr 2013 17:33:57 +0200, Aaron J. Seigo <aseigo at>  
> wrote:
>> On Thursday, April 25, 2013 15:11:25 Martin Briza wrote:
>>>   - The KDisplayManager class is used only on a few places so  
>>> replacing its
>>> constructions with calls to the factory will be easy.
>> i don't think KDisplayManager's public API needs to be changed in any  
>> way.
> The API itself wouldn't change. I'm just proposing usage of a singleton  
> factory class to have only one instance of the KDisplayManager class  
> instead of constructing the object all over. But say the word and I  
> implement it as you suggested below.

Started implementing it as you described, I'll let the singleton backend  
stay in KDisplayManager.
So far it seems there will be null (!defined(Q_WS_X11)), basic  
(legacy/current), systemd and maybe CK backends.
I'll push when I'm sure everything is okay into a new branch for you to  

More information about the kde-core-devel mailing list