Review Request 110083: Make kdepim libs optional dependency for libkfbapi

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110083/#review31872
-----------------------------------------------------------



LibKFbAPI-KDEPIMConfig.cmake.in
<http://git.reviewboard.kde.org/r/110083/#comment23766>

    CMake will stop at this point.
    
    Exported targets can only be loaded once.
    
    LibKFbAPITargetsWithPrefix.cmake is already loaded by LibKFbAPIConfig.cmake
    
    One solution is to change this line: install(TARGETS kfbapi kfbapikdepim EXPORT kfbapiLibraryTargets ${INSTALL_TARGETS_DEFAULT_ARGS}) to use a different export name for kfbapikdepim (and then install a different export file for this library) but then you also have to require a different CMake version (multiple export-sets in a given project is a 2.8.10 feature iirc)
    


- Christophe Giboudeaux


On April 29, 2013, 11:18 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110083/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 11:18 a.m.)
> 
> 
> Review request for kdelibs and KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5aefdcf 
>   LibKFbAPI-KDEPIM.pc.in PRE-CREATION 
>   LibKFbAPI-KDEPIMConfig.cmake.in PRE-CREATION 
>   LibKFbAPI.pc.in af537d1 
>   libkfbapi/CMakeLists.txt dac62bc 
>   libkfbapi/commentinfo.h e5578c7 
>   libkfbapi/kdepim-utils.h PRE-CREATION 
>   libkfbapi/kdepim-utils.cpp PRE-CREATION 
>   libkfbapi/likeinfo.h e06052e 
>   libkfbapi/noteinfo.h 2492db1 
>   libkfbapi/noteinfo.cpp 154593d 
>   libkfbapi/notificationinfo.h a882694 
>   libkfbapi/userinfo.h ac22a7e 
>   libkfbapi/userinfo.cpp 26c64da 
>   libkfbapi/userinfoparser_p.h 0189a17 
> 
> Diff: http://git.reviewboard.kde.org/r/110083/diff/
> 
> 
> Testing
> -------
> 
> Builds correctly here in both cases
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/