Review Request 110266: Cleanp Places Panel context menu

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110266/#review31871
-----------------------------------------------------------



kfile/kfileplacesmodel.cpp
<http://git.reviewboard.kde.org/r/110266/#comment23765>

    Forgot to remove the label argument everywhere. (Wouldn't i18n normally spawn an I18N_EXCESS_ARGUMENTS then? weird.)


- Kai Uwe Broulik


On May 2, 2013, 8:05 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110266/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 8:05 a.m.)
> 
> 
> Review request for kdelibs, KDE Usability, Aaron J. Seigo, and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> This is a follow-up review request for Review 109015 which does the same for Dolphin.
> 
> This patch cleans up the places panel context menu by:
>  - Removing the term "Entry" and the entry name in every single item. To still have easy context, I added a menu title instead.
>  - General actions such as "Show all" and "Add Entry" are removed from item context menus (they're not related to the item)
> 
> See screenshot for direct comparison of old and new.
> 
> You can still add an entry, even if the list is full, by scrolling to the bottom of the list where there is always an empty spot to click on. To me it sounds logical to add an entry at the end anyway. (Dolphin doesn't directly have this problem since you can always click the group titles (Devices, Places, Search For, …) which are not considered an item and thus spawn the general context menu)
> 
> For Frameworks 5 it would of course be great to merge Dolphin's places panel duplication back into kdelibs to provide a unified user experience and reduce maintenance cost. (Or write a new one based on QML, :P)
> 
> 
> Diffs
> -----
> 
>   kfile/kfileplacesmodel.cpp a73274c 
>   kfile/kfileplacesview.cpp 117a9ed 
> 
> Diff: http://git.reviewboard.kde.org/r/110266/diff/
> 
> 
> Testing
> -------
> 
> Tested in the Open File dialog of Kolourpaint. Looks nice, works.
> 
> 
> File Attachments
> ----------------
> 
> Comparison (left old, right new)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/kdelibsplaces.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130502/91890015/attachment.htm>