Review Request 108753: khtml/canvas: Do not throw an exception for Rect if width/height are negative

Commit Hook null at kde.org
Sat Mar 30 15:14:14 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108753/#review30152
-----------------------------------------------------------


This review has been submitted with commit ccde0d07389cd435119172d6d8973bc45adb4877 by Bernd Buschinski to branch master.

- Commit Hook


On Feb. 3, 2013, 4:43 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108753/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2013, 4:43 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> khtml/canvas: Do not throw an exception for Rect if width/height are negative, they are allowed and work.
> 
> According to:
> http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.rect.subpath
> and test:
> http://philip.html5.org/tests/canvas/suite/tests/2d.path.rect.negative.html
> 
> 
> Diffs
> -----
> 
>   khtml/html/html_canvasimpl.cpp 93d5db7 
> 
> Diff: http://git.reviewboard.kde.org/r/108753/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130330/6979daef/attachment.htm>


More information about the kde-core-devel mailing list