Review Request 108752: khtml/canvas: Do not throw an exception if width/height are negative for strokeRect

Commit Hook null at kde.org
Sat Mar 30 15:14:10 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108752/#review30151
-----------------------------------------------------------


This review has been submitted with commit 0004854a236421935721c3f0639a152e3020a957 by Bernd Buschinski to branch master.

- Commit Hook


On Feb. 3, 2013, 4:43 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108752/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2013, 4:43 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> khtml/canvas: Do not throw an exception if width/height are negative for strokeRect, they are supported and work.
> But do nothing if width AND height are zero.
> 
> According to:
> http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.strokeRect
> and test:
> http://philip.html5.org/tests/canvas/suite/tests/2d.strokeRect.negative.html
> 
> 
> Diffs
> -----
> 
>   khtml/html/html_canvasimpl.cpp 93d5db7 
> 
> Diff: http://git.reviewboard.kde.org/r/108752/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130330/0b8317ce/attachment.htm>


More information about the kde-core-devel mailing list