Review Request 108928: khtml/xml: if the content-type is null don't override mimeType and continue parsing the responseXML

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108928/#review30127
-----------------------------------------------------------


This review has been submitted with commit fac80df60524f9a489bd9665ffb3c373256d0229 by Bernd Buschinski to branch master.

- Commit Hook


On Feb. 12, 2013, 9:46 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108928/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 9:46 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> khtml/xml: if the content-type is null don't override mimeType and continue parsing the responseXML
> 
> In case the server does not set the content-type, the getResponseHeader("Content-Type",dummy); function will return jsNull, which is correct.
> As null is also valid, don't override the mimeType and leave it as "text/xml", so we actually do parse the reponse.
> 
> Confirmed by
> http://www.w3.org/TR/XMLHttpRequest/#document-response-entity-body
> "If final MIME type is not null, text/html, text/xml, application/xml, or does not end in +xml, return null and terminate these steps."
> ~~
> means, if it is one of these above -> continue
> 
> 
> Diffs
> -----
> 
>   khtml/ecma/xmlhttprequest.cpp cd72fe8 
> 
> Diff: http://git.reviewboard.kde.org/r/108928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130330/f0e37fab/attachment.htm>