Review Request 106671: kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106671/#review30121
-----------------------------------------------------------


This review has been submitted with commit b69affd87c2368dba436d26570fd372c07503717 by Bernd Buschinski to branch master.

- Commit Hook


On Jan. 22, 2013, 3:11 a.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106671/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 3:11 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it
> 
> that adds all html functionality to the javascript Audio.
> Previous one just had pause/play/stop/omload/onerror and
> NOTE "stop" is not even part of the HTMLAudioElement/HTMLMediaElement(.idl), so its removed now.
> 
> 
> Diffs
> -----
> 
>   khtml/CMakeLists.txt 99034cc 
>   khtml/ecma/kjs_audio.h 956d72a 
>   khtml/ecma/kjs_audio.cpp f67cdc9 
> 
> Diff: http://git.reviewboard.kde.org/r/106671/diff/
> 
> 
> Testing
> -------
> 
> Makes websites like
> http://release.blackmesasource.com/?sm2-preferflash=false
> and
> http://9elements.com/html5demos/audio/
> from the javascript point of view
> 
> not 100% as the html element is still missing some implementations
> e.g. scheduleLoad and canplay event
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130330/a221aeda/attachment.htm>