Review Request 105430: kjs: Implement html5 HTMLSelectCollectionProtoFunc::remove

Commit Hook null at kde.org
Sat Mar 30 15:12:04 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105430/#review30118
-----------------------------------------------------------


This review has been submitted with commit 60ad547400ed1c2cb0e6fc53636edfd650877d10 by Bernd Buschinski to branch master.

- Commit Hook


On Jan. 22, 2013, 3:11 a.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105430/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 3:11 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement html5 HTMLSelectCollectionProtoFunc::remove
> 
> with this
> 
> getElementById("mySELECT").options.remove(index)
> getElementById("mySELECT").remove(index)
> 
> works as described in 
> http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#dom-htmloptionscollection-remove
> 
> 
> Diffs
> -----
> 
>   khtml/ecma/kjs_html.h 37980b9 
>   khtml/ecma/kjs_html.cpp 9f8f6d0 
> 
> Diff: http://git.reviewboard.kde.org/r/105430/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130330/3f486c68/attachment.htm>


More information about the kde-core-devel mailing list