Review Request 109748: kioslave/sftp: Show correct port number when connecting to default port

[Andreas Hartmetz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109748/#review30000
-----------------------------------------------------------

Ship it!


Ship It!

- Andreas Hartmetz


On March 26, 2013, 8:18 p.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109748/
> -----------------------------------------------------------
> 
> (Updated March 26, 2013, 8:18 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Currently, if you make a sftp connection through the kio slave, this slave shows port number 0 to the user in the status bar (and as debug output) instead of the ssh port number 22. This is purely an UI issue, as internally the port number is tested on >0 using the default port number as a fall back if the test fails.
> The attached patch address this issue by testing for port number 0. If the port number is invalid, the default port number is shown instead.
> 
> 
> Diffs
> -----
> 
>   kioslave/sftp/kio_sftp.cpp f493477 
> 
> Diff: http://git.reviewboard.kde.org/r/109748/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130328/93f698fa/attachment.htm>