Review Request 109233: Make nfs isSlow() user configurable in kdeglobals, fixes Bug 290666

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109233/#review29643
-----------------------------------------------------------


The right solution is to make icon loading delayed. For everyone in all cases. Then it won't be a bottleneck anymore, on slow servers.

I thought Martin Koller was working on that, but it seems to have stalled.

Making this configurable is only a poor man's fix compared to the right fix, but if you 


kio/kio/kfileitem.cpp
<http://git.reviewboard.kde.org/r/109233/#comment22093>

    No, use KGlobal::config() instead, much faster than parsing kdeglobals everytime!


- David Faure


On March 1, 2013, 5:20 p.m., Pierre Sauter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109233/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 5:20 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> NFS (and smb) filesystems are considered slow by KDE and icons from those are not shown in folderview.
> see https://bugs.kde.org/show_bug.cgi?id=290666
> In corporate environments this is not an expected behaviour, as home directories are usually mounted over the network.
> This patch restores the old behaviour by having the line
> showIconsOnNetworkFilesystems=true
> in the General section of kdeglobals.
> 
> 
> This addresses bug 290666.
>     http://bugs.kde.org/show_bug.cgi?id=290666
> 
> 
> Diffs
> -----
> 
>   kio/kio/kfileitem.cpp 6667a90ee9e1d57488bb7e085167658f2fb9f172 
> 
> Diff: http://git.reviewboard.kde.org/r/109233/diff/
> 
> 
> Testing
> -------
> 
> Built kde4libs_4.10.0 from source on Ubuntu 12.04.
> Works as expected.
> 
> 
> Thanks,
> 
> Pierre Sauter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130321/199ccf2a/attachment.htm>