Review Request 109551: port KPtyProcess to QProcess

[Oswald Buddenhagen]

> On March 18, 2013, 10:04 p.m., Oswald Buddenhagen wrote:
> > kpty/tests/kptyprocesstest.cpp, line 193
> > <http://git.reviewboard.kde.org/r/109551/diff/2/?file=120310#file120310line193>
> >
> >     i don't think eating the sleep is a good idea. i'm sure i added it for a reason (in a previous life ^^).
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     with the sleep the test fails, and even with high load I can't get the test to fail without it.

hmm, that means that something is actually broken in the port ... i'll need to look at it a bit more thoroughly. don't expect this to happen before the weekend.


> On March 18, 2013, 10:04 p.m., Oswald Buddenhagen wrote:
> > kpty/tests/kptyprocesstest.cpp, line 210
> > <http://git.reviewboard.kde.org/r/109551/diff/2/?file=120310#file120310line210>
> >
> >     the -c needs to be a separate argument.
> >     
> >     the quotes, backslashes and attempt at a newline are all garbage.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     I first had -c as a separate argument, and it didn't matter. And I had to add an extra newline to get it to work with doing it manually.

well, i'm just telling you how it should be, i.e., what setShellCommand() did. if that doesn't work, we have a real problem - most likely related to the other failure.


- Oswald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109551/#review29478
-----------------------------------------------------------


On March 18, 2013, 7:54 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109551/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 7:54 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, David Faure, and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> Just a simple port of KPtyProcess away from using KProcess.
> 
> 
> Diffs
> -----
> 
>   kpty/kptyprocess.h 5e0df96 
>   kpty/kptyprocess.cpp 015a58c 
>   kpty/tests/kptyprocesstest.cpp 04990a0 
> 
> Diff: http://git.reviewboard.kde.org/r/109551/diff/
> 
> 
> Testing
> -------
> 
> builds and tests pass.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130319/90e81cf0/attachment.htm>