Review Request 109551: port KPtyProcess to QProcess
Jan Kundrát
jkt at flaska.net
Mon Mar 18 11:15:58 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109551/#review29432
-----------------------------------------------------------
kpty/tests/kptyprocesstest.h
<http://git.reviewboard.kde.org/r/109551/#comment21974>
Why are these commented out instead of being removed?
- Jan Kundrát
On March 17, 2013, 4:44 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109551/
> -----------------------------------------------------------
>
> (Updated March 17, 2013, 4:44 p.m.)
>
>
> Review request for KDE Frameworks, kdelibs and David Faure.
>
>
> Description
> -------
>
> Just a simple port of KPtyProcess away from using KProcess.
>
>
> Diffs
> -----
>
> kpty/kptyprocess.h 5e0df96
> kpty/kptyprocess.cpp 015a58c
> kpty/tests/kptyprocesstest.h 64bded0
> kpty/tests/kptyprocesstest.cpp 04990a0
>
> Diff: http://git.reviewboard.kde.org/r/109551/diff/
>
>
> Testing
> -------
>
> builds and tests pass.
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130318/730ecffb/attachment.htm>
More information about the kde-core-devel
mailing list