Review Request 109538: port KFileMetaDataReader to QProcess

[Kevin Ottens]

> On March 17, 2013, 2:05 p.m., Vishesh Handa wrote:
> > But why? KFileMetadataReader and the other KFileMetadataStuff should just be marked as deprecated. Why are we porting them? We already have better alternatives in the nepomuk-widgets repository.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     Because it was a simple user of KProcess.
>     
>     But if we can just deprecate the whole class (and move it into kde4support, I guess?) that's better. :-)
> 
> Vishesh Handa wrote:
>     As far as I'm concerned it can be deprecated. We can definitely deprecate KFileMetadataWidget which is the only user of this KFileMetadataReader. Dolphin now uses Nepomuk2::FileMetadataWidget. The only slight problem might be that Dolphin still likes being "Nepomuk Optional" at compile time. So they still use it. Maybe we should talk to Frank about this?
>     
>     The only other class is KFileMetaInfo, which uses Strigi directly. I still have to write a replacement for that in Nepomuk.
>     
>     @David: I think we talked about this in Berlin. Should we deprecate KFileMetadataWidget?

Yep, that's what we discussed in Berlin, this one could move to kde4support indeed.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109538/#review29377
-----------------------------------------------------------


On March 17, 2013, 1:26 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109538/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 1:26 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, David Faure, and Vishesh Handa.
> 
> 
> Description
> -------
> 
> KFileMetaDataReader currently uses KProcess, this ports it to use QProcess instead.
> 
> 
> Diffs
> -----
> 
>   kio/kfile/kfilemetadatareader.cpp 88cadaa 
> 
> Diff: http://git.reviewboard.kde.org/r/109538/diff/
> 
> 
> Testing
> -------
> 
> it builds.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130318/da6abe03/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel