Review Request 109404: Give more precedence to qmake executable names that specify the version

[Thiago Macieira]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109404/#review28925
-----------------------------------------------------------


ArchLinux's setup is completely unsupported. I was quite clear: "qmake" must point by default to Qt 4 if Qt 4 present.

Let them fix on their side.


kdecore/auth/ConfigureChecks.cmake
<http://git.reviewboard.kde.org/r/109404/#comment21624>

    Unrelated change



kdecore/auth/ConfigureChecks.cmake
<http://git.reviewboard.kde.org/r/109404/#comment21625>

    Unrelated change.



kdecore/auth/ConfigureChecks.cmake
<http://git.reviewboard.kde.org/r/109404/#comment21627>

    Unrelated change.



plasma/corona.cpp
<http://git.reviewboard.kde.org/r/109404/#comment21626>

    Unrelated change.



plasma/tooltipmanager.cpp
<http://git.reviewboard.kde.org/r/109404/#comment21628>

    Unrelated change.



solid/solid/backends/udev/udevmanager.cpp
<http://git.reviewboard.kde.org/r/109404/#comment21629>

    Unrelated change.


- Thiago Macieira


On March 11, 2013, 1:16 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109404/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 1:16 a.m.)
> 
> 
> Review request for Build System, kdelibs, David Faure, and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> Recently ArchLinux decided to ship Qt5 and they did so by making qmake point to qmake-qt5 and adding qmake-qt4.
> 
> With this patch, we look first for the executables that specify the version number and then the more generic ones.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQt4.cmake 6db944f 
>   kdecore/auth/ConfigureChecks.cmake 7cf9cb5 
>   plasma/corona.cpp 5c90aa4 
>   plasma/tooltipmanager.cpp d90dc9c 
>   solid/solid/backends/udev/udevmanager.cpp b0c83c9 
> 
> Diff: http://git.reviewboard.kde.org/r/109404/diff/
> 
> 
> Testing
> -------
> 
> cmake_minimum_required(VERSION 2.8)
> 
> find_package(KDE4)
> 
> -----
> 
> Configuring such a project returns the correct versions.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130311/6c89143e/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem at kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem