Review Request 109385: Fix parse error in advanced memroy information for 3.8 kernels

Commit Hook null at kde.org
Sun Mar 10 10:15:44 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109385/#review28868
-----------------------------------------------------------


This review has been submitted with commit ecd6271126e7579390183f188d263722381be86a by Ralf Jung to branch master.

- Commit Hook


On March 10, 2013, 9:54 a.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109385/
> -----------------------------------------------------------
> 
> (Updated March 10, 2013, 9:54 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> This patch fixes a parse error which the advanced memory information shows for 3.8 kernels. These kernels have new lines like this in /proc/*/smaps:
> 
>   VmFlags: rd ex
> 
> I changed the script to explicitly ignore these. It may be more future-proof to just ignore all unknown lines - please tell me if that solution is preferred.
> 
> I intend to push this to stable and master.
> 
> 
> This addresses bug 314818.
>     http://bugs.kde.org/show_bug.cgi?id=314818
> 
> 
> Diffs
> -----
> 
>   libs/ksysguard/scripts/smaps/main.js fb938c4 
> 
> Diff: http://git.reviewboard.kde.org/r/109385/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed, tested that "Advanced Memory Information" is working again.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130310/ae4d6713/attachment.htm>


More information about the kde-core-devel mailing list