Review Request 109060: [KMenuEdit] Ability to move up/down items

[Julien Borderie]

> On March 7, 2013, 2:56 p.m., Albert Astals Cid wrote:
> > kmenuedit/kmenueditui.rc, line 41
> > <http://git.reviewboard.kde.org/r/109060/diff/4/?file=117095#file117095line41>
> >
> >     Code looks fine, i'm just asking myself if we really need this in the toolbar in addition to the menu and the contextual menu. Seems like the toolbar is getting bigger and bigger. What do you think?

Albert,

I think these both actions have their place in the toolbar for a quick access, but I'm agree with you.

Soon, I will simplify toolbar sorting actions into a single item, rather than two ("selection only"/"all").

According to me, the GUI should be reworked : some explicit toolbar items can be displayed without text, contextual menu items can be reordered.
But since there is no active maintainer, who can take the decision to change the GUI ? Does a (simple) contributor like me can do it ?

Thank you


- Julien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109060/#review28763
-----------------------------------------------------------


On March 5, 2013, 5:48 p.m., Julien Borderie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109060/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 5:48 p.m.)
> 
> 
> Review request for kde-workspace and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Hi,
> 
> This patch adds 2 actions to move up/down items in KMenuEdit.
> It makes easier item moving, a drag'n'drop is no longer required to move an item inside its parent node.
> All changes are taken into consideration while saving.
> 
> ----
> Note bene : "moveUpOrDownItem(int isMovingUpAction)" method takes an integer rather than a boolean because of the use of a QSignalMapper, that does not handle boolean types.
> 
> 
> This addresses bug 61537.
>     http://bugs.kde.org/show_bug.cgi?id=61537
> 
> 
> Diffs
> -----
> 
>   kmenuedit/kmenuedit.cpp 7f9ee9f 
>   kmenuedit/kmenueditui.rc 3b0f4b9 
>   kmenuedit/treeview.h d36ca85 
>   kmenuedit/treeview.cpp 9d94ee5 
> 
> Diff: http://git.reviewboard.kde.org/r/109060/diff/
> 
> 
> Testing
> -------
> 
> 1) Move down
> - Select the first item on a given tree node --> "move up" action disabled, "move down" action enabled
> - Apply "Move down" action --> item moved down
> 
> 2) Move up
> - Select the last item on a given tree node --> "move up" action enabled, "move down" action disabled
> - Apply "Move up" action --> item moved up
> 
> 
> Thanks,
> 
> Julien Borderie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130307/ac018fe8/attachment.htm>