Review Request 109060: [KMenuEdit] Ability to move up/down items

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109060/#review28560
-----------------------------------------------------------


 * Start kmenuedit
 * Press the move down button
 * Crash
#0  0x00007ffff7bb83d4 in QTreeWidgetItem::parent (this=0x0) at /usr/include/qt4/QtGui/qtreewidget.h:183
#1  0x00007ffff7bb6200 in TreeView::getParentItem (this=0x790900, item=0x0) at /home/kdeunstable/kde-workspace/kmenuedit/treeview.cpp:1672
#2  0x00007ffff7bb608f in TreeView::moveUpOrDownItem (this=0x790900, isMovingUpAction=false) at /home/kdeunstable/kde-workspace/kmenuedit/treeview.cpp:1624
#3  0x00007ffff7bb6057 in TreeView::moveDownItem (this=0x790900) at /home/kdeunstable/kde-workspace/kmenuedit/treeview.cpp:1611
#4  0x00007ffff7bae88f in TreeView::qt_static_metacall (_o=0x790900, _c=QMetaObject::InvokeMetaMethod, _id=17, _a=0x7fffffffcdd0) at /home/kdeunstable/build/kde-workspace/kmenuedit/treeview.moc:97
#5  0x00007ffff50fef5f in QMetaObject::activate (sender=0x78b770, m=<optimized out>, local_signal_index=<optimized out>, argv=0x7fffffffcdd0) at kernel/qobject.cpp:3547
#6  0x00007ffff5b51ba1 in QAction::activated (this=this at entry=0x78b770, _t1=-16) at .moc/release-shared/moc_qaction.cpp:297
#7  0x00007ffff5b51c36 in QAction::activate (this=0x78b770, event=<optimized out>) at kernel/qaction.cpp:1260
#8  0x00007ffff5f1651f in QAbstractButtonPrivate::click (this=this at entry=0x7b5db0) at widgets/qabstractbutton.cpp:530
#9  0x00007ffff5f167cc in QAbstractButton::mouseReleaseEvent (this=0x7dcf10, e=0x7fffffffd6b0) at widgets/qabstractbutton.cpp:1123
#10 0x00007ffff5fd099a in QToolButton::mouseReleaseEvent (this=<optimized out>, e=<optimized out>) at widgets/qtoolbutton.cpp:718
#11 0x00007ffff5ba7850 in QWidget::event (this=0x7dcf10, event=0x7fffffffd6b0) at kernel/qwidget.cpp:8371
#12 0x00007ffff5b57e9c in QApplicationPrivate::notify_helper (this=this at entry=0x63c940, receiver=receiver at entry=0x7dcf10, e=e at entry=0x7fffffffd6b0) at kernel/qapplication.cpp:4562
#13 0x00007ffff5b5cb6b in QApplication::notify (this=<optimized out>, receiver=0x7dcf10, e=0x7fffffffd6b0) at kernel/qapplication.cpp:4105
#14 0x00007ffff68b5c52 in KApplication::notify (this=0x7fffffffe300, receiver=0x7dcf10, event=0x7fffffffd6b0) at /home/kdeunstable/kdelibs/kdeui/kernel/kapplication.cpp:311
#15 0x00007ffff50e956e in QCoreApplication::notifyInternal (this=0x7fffffffe300, receiver=0x7dcf10, event=0x7fffffffd6b0) at kernel/qcoreapplication.cpp:915
#16 0x00007ffff5b58cd3 in sendEvent (event=<optimized out>, receiver=<optimized out>) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:231
#17 QApplicationPrivate::sendMouseEvent (receiver=0x7dcf10, event=0x7fffffffd6b0, alienWidget=0x7dcf10, nativeWidget=0x7121d0, buttonDown=0x7ffff6634308 <qt_button_down>, lastMouseReceiver=..., spontaneous=true) at kernel/qapplication.cpp:3173
#18 0x00007ffff5bd6554 in QETWidget::translateMouseEvent (this=this at entry=0x7121d0, event=event at entry=0x7fffffffde30) at kernel/qapplication_x11.cpp:4622
#19 0x00007ffff5bd544f in QApplication::x11ProcessEvent (this=0x7fffffffe300, event=0x7fffffffde30) at kernel/qapplication_x11.cpp:3737
#20 0x00007ffff5bfcfa2 in x11EventSourceDispatch (s=s at entry=0x63e070, callback=0x0, user_data=0x0) at kernel/qguieventdispatcher_glib.cpp:146
#21 0x00007ffff1517ab5 in g_main_dispatch (context=0x63dc20) at /build/buildd/glib2.0-2.34.1/./glib/gmain.c:2715
#22 g_main_context_dispatch (context=context at entry=0x63dc20) at /build/buildd/glib2.0-2.34.1/./glib/gmain.c:3219
#23 0x00007ffff1517de8 in g_main_context_iterate (context=context at entry=0x63dc20, block=block at entry=1, dispatch=dispatch at entry=1, self=<optimized out>) at /build/buildd/glib2.0-2.34.1/./glib/gmain.c:3290
#24 0x00007ffff1517ea4 in g_main_context_iteration (context=0x63dc20, may_block=1) at /build/buildd/glib2.0-2.34.1/./glib/gmain.c:3351
#25 0x00007ffff5117bf6 in QEventDispatcherGlib::processEvents (this=0x609540, flags=...) at kernel/qeventdispatcher_glib.cpp:424
#26 0x00007ffff5bfcc1e in QGuiEventDispatcherGlib::processEvents (this=<optimized out>, flags=...) at kernel/qguieventdispatcher_glib.cpp:204
#27 0x00007ffff50e82bf in QEventLoop::processEvents (this=this at entry=0x7fffffffe200, flags=...) at kernel/qeventloop.cpp:149
#28 0x00007ffff50e8548 in QEventLoop::exec (this=0x7fffffffe200, flags=...) at kernel/qeventloop.cpp:204
#29 0x00007ffff50ed708 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1187
#30 0x00007ffff7ba7e7b in kdemain (argc=2, argv=0x7fffffffe438) at /home/kdeunstable/kde-workspace/kmenuedit/main.cpp:87
#31 0x00000000004007fe in main (argc=2, argv=0x7fffffffe438) at /home/kdeunstable/build/kde-workspace/kmenuedit/kmenuedit_dummy.cpp:3


- Albert Astals Cid


On March 4, 2013, 5:59 p.m., Julien Borderie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109060/
> -----------------------------------------------------------
> 
> (Updated March 4, 2013, 5:59 p.m.)
> 
> 
> Review request for kde-workspace and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Hi,
> 
> This patch adds 2 actions to move up/down items in KMenuEdit.
> It makes easier item moving, a drag'n'drop is no longer required to move an item inside its parent node.
> All changes are taken into consideration while saving.
> 
> ----
> Note bene : "moveUpOrDownItem(int isMovingUpAction)" method takes an integer rather than a boolean because of the use of a QSignalMapper, that does not handle boolean types.
> 
> 
> This addresses bug 61537.
>     http://bugs.kde.org/show_bug.cgi?id=61537
> 
> 
> Diffs
> -----
> 
>   kmenuedit/kmenuedit.cpp 7f9ee9f 
>   kmenuedit/kmenueditui.rc 3b0f4b9 
>   kmenuedit/treeview.h d36ca85 
>   kmenuedit/treeview.cpp 9d94ee5 
> 
> Diff: http://git.reviewboard.kde.org/r/109060/diff/
> 
> 
> Testing
> -------
> 
> 1) Move down
> - Select the first item on a given tree node --> "move up" action disabled, "move down" action enabled
> - Apply "Move down" action --> item moved down
> 
> 2) Move up
> - Select the last item on a given tree node --> "move up" action enabled, "move down" action disabled
> - Apply "Move up" action --> item moved up
> 
> 
> Thanks,
> 
> Julien Borderie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130304/15c827d8/attachment.htm>