Review Request 109245: Remove duplicated calendar classes from calendar plasmoid

Sergio Luis Martins iamsergio at gmail.com
Sat Mar 2 14:12:48 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109245/
-----------------------------------------------------------

(Updated March 2, 2013, 2:12 p.m.)


Review request for kde-workspace and John Layt.


Description
-------

kde-workspace had a few classes that were duplicated in kdepim.
In 4.10 they were moved from kdepim to kdepimlibs, so now kde-workspace can use that instead of duplicating.


Diffs (updated)
-----

  plasma/generic/dataengines/calendar/CMakeLists.txt 5539f99 
  plasma/generic/dataengines/calendar/akonadi/README.txt dc1d36c 
  plasma/generic/dataengines/calendar/akonadi/blockalarmsattribute.h 71c8284 
  plasma/generic/dataengines/calendar/akonadi/blockalarmsattribute.cpp 28dff0c 
  plasma/generic/dataengines/calendar/akonadi/calendar.h 364fc81 
  plasma/generic/dataengines/calendar/akonadi/calendar.cpp 8ff81ef 
  plasma/generic/dataengines/calendar/akonadi/calendar_p.h f9b92de 
  plasma/generic/dataengines/calendar/akonadi/calendarmodel.h 1acbfdd 
  plasma/generic/dataengines/calendar/akonadi/calendarmodel.cpp 251a615 
  plasma/generic/dataengines/calendar/akonadi/calfilterproxymodel.h fe62155 
  plasma/generic/dataengines/calendar/akonadi/calfilterproxymodel.cpp 1820084 
  plasma/generic/dataengines/calendar/akonadi/collectionselection.h 4447afb 
  plasma/generic/dataengines/calendar/akonadi/collectionselection.cpp 41e03da 
  plasma/generic/dataengines/calendar/akonadi/utils.h d923594 
  plasma/generic/dataengines/calendar/akonadi/utils.cpp 895edf9 
  plasma/generic/dataengines/calendar/calendarengine.h 18ae774 
  plasma/generic/dataengines/calendar/calendarengine.cpp 7235f74 
  plasma/generic/dataengines/calendar/eventdatacontainer.h b170a14 
  plasma/generic/dataengines/calendar/eventdatacontainer.cpp 63db4df 

Diff: http://git.reviewboard.kde.org/r/109245/diff/


Testing
-------

Used "plasmoidviewer calendar" to test.


Thanks,

Sergio Luis Martins

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130302/eaf7c40b/attachment.htm>


More information about the kde-core-devel mailing list