Review Request 109060: [KMenuEdit] Ability to move up/down items

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109060/#review28355
-----------------------------------------------------------



kmenuedit/treeview.cpp
<http://git.reviewboard.kde.org/r/109060/#comment21177>

    If you are going to use the ugly signal mapper, you should use 1 and 0 not true and false


- Albert Astals Cid


On Feb. 20, 2013, 7:50 p.m., Julien Borderie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109060/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2013, 7:50 p.m.)
> 
> 
> Review request for kde-workspace and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Hi,
> 
> This patch adds 2 actions to move up/down items in KMenuEdit.
> It makes easier item moving, a drag'n'drop is no longer required to move an item inside its parent node.
> All changes are taken into consideration while saving.
> 
> ----
> Note bene : "moveUpOrDownItem(int isMovingUpAction)" method takes an integer rather than a boolean because of the use of a QSignalMapper, that does not handle boolean types.
> 
> 
> This addresses bug 61537.
>     http://bugs.kde.org/show_bug.cgi?id=61537
> 
> 
> Diffs
> -----
> 
>   kmenuedit/kmenuedit.cpp 7f9ee9f 
>   kmenuedit/kmenueditui.rc 3b0f4b9 
>   kmenuedit/treeview.h d36ca85 
>   kmenuedit/treeview.cpp 9d94ee5 
> 
> Diff: http://git.reviewboard.kde.org/r/109060/diff/
> 
> 
> Testing
> -------
> 
> 1) Move down
> - Select the first item on a given tree node --> "move up" action disabled, "move down" action enabled
> - Apply "Move down" action --> item moved down
> 
> 2) Move up
> - Select the last item on a given tree node --> "move up" action enabled, "move down" action disabled
> - Apply "Move up" action --> item moved up
> 
> 
> Thanks,
> 
> Julien Borderie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130301/b37187b9/attachment.htm>