Review Request 111183: Move KLanguageButton to KWidgets
Andrea Scarpino
scarpino at kde.org
Sat Jun 22 19:25:48 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111183/
-----------------------------------------------------------
(Updated June 22, 2013, 8:25 p.m.)
Review request for kdelibs and Kevin Ottens.
Changes
-------
Patch was incomplete.
Description
-------
The KLocate code is commented. I don't know if this is OK, or if I've to port it to QLocale first and then it can be moved to kwidgets.
This patch must be applied with the others 2 that I'm going to push later.
KHelpMenu uses KLanguageButton through KSwitchLanguageDialogPrivate.
Diffs (updated)
-----
kdeui/CMakeLists.txt 3946ebf
kdeui/widgets/klanguagebutton.h feb2b5b
kdeui/widgets/klanguagebutton.cpp c5d8e4b
staging/kwidgets/src/CMakeLists.txt 03a7d7a
staging/kwidgets/src/widgets/klanguagebutton.h PRE-CREATION
staging/kwidgets/src/widgets/klanguagebutton.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111183/diff/
Testing
-------
Builds.
Thanks,
Andrea Scarpino
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130622/36187e44/attachment.htm>
More information about the kde-core-devel
mailing list