Review Request 111090: Deprecate kdeui/widgets/kstringvalidator.* and kio/kfile/kfilemetainfowidget.*

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111090/#review34746
-----------------------------------------------------------


This review has been submitted with commit 326531d3d7090195ec7ea7c904d3a8eb583aaa3d by Kevin Ottens to branch frameworks.

- Commit Hook


On June 18, 2013, 1:08 p.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111090/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 1:08 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Description
> -------
> 
> Since, according to lxr, both these classes aren't used by anyone, I just marked them as deprecated and moved them to kde4support.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt cb30283 
>   kdeui/widgets/kstringvalidator.h 01dbec6 
>   kdeui/widgets/kstringvalidator.cpp c4fcc21 
>   kio/CMakeLists.txt 9254283 
>   kio/kfile/kfilemetainfowidget.h eaebcc8 
>   kio/kfile/kfilemetainfowidget.cpp d0f74df 
>   staging/kde4support/src/CMakeLists.txt f89e845 
>   staging/kde4support/src/kdeui/kstringvalidator.h PRE-CREATION 
>   staging/kde4support/src/kdeui/kstringvalidator.cpp PRE-CREATION 
>   staging/kde4support/src/kio/kfilemetainfowidget.h PRE-CREATION 
>   staging/kde4support/src/kio/kfilemetainfowidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111090/diff/
> 
> 
> Testing
> -------
> 
> kdelibs compiles after the move. There weren't any tests for them anywhere and I didn't bother to write any, since they're being deprecated -- I assume that's OK.
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130620/49c07810/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel