Review Request 111072: Drop internal X11 cmake module

Alexander Neundorf neundorf at kde.org
Mon Jun 17 21:17:13 BST 2013



> On June 17, 2013, 6:34 p.m., Alexander Neundorf wrote:
> > No other changes at all necessary ?
> 
> Andrea Scarpino wrote:
>     kdelibs does not use any of the variables listed in the ECM_SiC page

Then it's probably ok.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111072/#review34519
-----------------------------------------------------------


On June 17, 2013, 3:35 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111072/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 3:35 p.m.)
> 
> 
> Review request for kdelibs and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> Use upstream one.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/CMakeLists.txt 25ea009 
>   cmake/modules/FindX11.cmake f2f879d 
> 
> Diff: http://git.reviewboard.kde.org/r/111072/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130617/1e005733/attachment.htm>


More information about the kde-core-devel mailing list