Review Request 111070: Drop internal PostgreSQL cmake module

Andrea Scarpino scarpino at kde.org
Mon Jun 17 19:35:52 BST 2013



> On June 17, 2013, 8:32 p.m., Alexander Neundorf wrote:
> > It is not used anywhere ?
> > http://techbase.kde.org/Development/ECM_SourceIncompatChanges#FindPostgreSQL.cmake lists a few renamed variables, but there are no such changes in this patch ?

It's not.
I did run 'fgrep -R' for each variable/method changed.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111070/#review34516
-----------------------------------------------------------


On June 17, 2013, 5:27 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111070/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 5:27 p.m.)
> 
> 
> Review request for kdelibs and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> Use upstream one.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/CMakeLists.txt 25ea009 
>   cmake/modules/FindPostgreSQL.cmake 7955612 
> 
> Diff: http://git.reviewboard.kde.org/r/111070/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130617/713829be/attachment.htm>


More information about the kde-core-devel mailing list