Review Request 111048: Prevent Konqueror from performing lots of stat calls during session auto save

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111048/
-----------------------------------------------------------

(Updated June 17, 2013, 1:07 p.m.)


Review request for KDE Base Apps and David Faure.


Changes
-------

- Fixed the last remaining stat call that happens every 10 secs.
- Cleaned up the code.


Description
-------

The attached patch changes KonqSessionManager such that it creates an instance of the auto save session KConfig object once during initialization instead of each time it is invoked, which is about every 10 secs. This stops the flood of "stat" calls from Konqueror that occur every 10 secs even when  Konqueror is doing absolutely nothing. The problem and its fix can be tested by running Konqueror through strace, "strace -e stat konqueror".

The result of this fix is the number of stat calls Konqueror makes every 10 secs went down to 1 from 15. Even that remaining stat call can be stopped if I was certain that removing the "deleteOwnedSessions" call from autoSaveSession won't cause any regression. David?


Diffs (updated)
-----

  konqueror/src/konqsessionmanager.h 930a2c3 
  konqueror/src/konqsessionmanager.cpp 1b99cb7 

Diff: http://git.reviewboard.kde.org/r/111048/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130617/549354c2/attachment.htm>