Review Request 110964: kioclient: error messages do not identify their source

[Jonathan Marten]

> On June 12, 2013, 8:45 p.m., David Faure wrote:
> > kioclient/kioclient.cpp, line 393
> > <http://git.reviewboard.kde.org/r/110964/diff/1/?file=149640#file149640line393>
> >
> >     The %2/%1 order is a bit surprising, but ok, why not :-)

Though it may be better not to change the already existing substitution, but can correct this for consistency with the other error messages.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110964/#review34250
-----------------------------------------------------------


On June 12, 2013, 12:15 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110964/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 12:15 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> While investigating another problem (which turned out to be not the fault of KDE at all), I encountered this mysterious message on stderr:
> 
> Syntax Error: Not enough arguments
> 
> It took a long time to track down the source of this message and find out that it was from kioclient.  If kioclient had given its name in the error message, as most Unix commands do, then the source of the message would have been obvious and made investigation easier.
> 
> 
> Diffs
> -----
> 
>   kioclient/kioclient.cpp d879980 
> 
> Diff: http://git.reviewboard.kde.org/r/110964/diff/
> 
> 
> Testing
> -------
> 
> Built kioclient with these changes, verified error message output.
> 
> $ kioclient exec
> kioclient: Syntax error, not enough arguments
> $ kioclient exec a b c
> kioclient: Syntax error, too many arguments
> $ kioclient foo
> kioclient: Syntax error, unknown command 'foo'
> $
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130613/fa84bb94/attachment.htm>