Review Request 110944: Send "modified" metaData when moving files through copy()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110944/#review34112
-----------------------------------------------------------



kio/kio/job.cpp
<http://git.reviewboard.kde.org/r/110944/#comment25052>

    Wait, why if (m_move)?
    I think we want to preserve the mtime also in case of a copy.
    I always said that KIO was emulating cp -a rather than cp.
    
    E.g. FileCopyJobPrivate::startDataPump() sets the mtime too (that's a get+put copy oepration).
    
    And bug 55804 talks about copying too. This is useful when archiving files to SFTP for instance.


- David Faure


On June 10, 2013, 9:41 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110944/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 9:41 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch fixes KIO::FileCopyJob job so that it sends the "modified" meta-data for move requests done through an ioslave's "copy(...)" function, i.e. ioslave has copyFromFile/copyToFile set to true. 
> 
> Note that this is only the job portion of the fix. Any ioslave that implements support for the aforementioned properties needs to properly set the mtime after it finishes the copying process.
> 
> 
> This addresses bug 55804.
>     http://bugs.kde.org/show_bug.cgi?id=55804
> 
> 
> Diffs
> -----
> 
>   kio/kio/job.cpp 05b0e65 
> 
> Diff: http://git.reviewboard.kde.org/r/110944/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130611/694857a5/attachment.htm>