Review Request 106581: Make KFileDialog remember settings

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106581/#review34066
-----------------------------------------------------------


This review has been submitted with commit c59c20a325098a55387544c7b670a5ca075d94ba by Aurélien Gâteau to branch master.

- Commit Hook


On June 10, 2013, 5:22 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106581/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 5:22 p.m.)
> 
> 
> Review request for kdelibs and Andreas Pakulat.
> 
> 
> Description
> -------
> 
> This patch makes KFileDialog remember settings such as which view mode is selected and whether the places sidebar should be visible.
> 
> Original code tried to save those to kdeglobals so that changes would be shared among all applications but it did so the wrong way. The patch writes the configuration to kdeglobals correctly, but saves the KDirOperator to the application config file (KDirOperator configuration settings are sort settings, show preview, show hidden files, view style (icon, detail, treeview))
> 
> There are two reasons for not saving KDirOperator config to kdeglobals:
> 
> 1. It is right now not possible to tell KDirOperator::writeConfig() to save to kdeglobals. It could be done by adding a new version of writeConfig() which would accept a KConfigBase::WriteFlags argument though.
> 
> 2. It probably would not be a good idea to remember KDirOperator settings globally anyway because depending on the application one may want to use different settings.
> For example if user wants to select images or videos he might set the file dialog to show big icons and the preview pane (so that videos can be played). This setup would however not be adapted in an application where one wants to select a text file.
> 
> 
> This addresses bug 139475.
>     http://bugs.kde.org/show_bug.cgi?id=139475
> 
> 
> Diffs
> -----
> 
>   kfile/kfilewidget.cpp 276861dcb2b761b9788506ccd281f22978e26f61 
> 
> Diff: http://git.reviewboard.kde.org/r/106581/diff/
> 
> 
> Testing
> -------
> 
> Tested with two different KDE applications. Settings are correctly remembered.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130610/0c07c5e2/attachment.htm>