Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

Dawit Alemayehu adawit at
Mon Jun 10 16:37:28 BST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated June 10, 2013, 3:37 p.m.)

Review request for kdelibs and David Faure.


Use itemForUrl instead of a new QCache to store type information.


This patch, inspired by the issue reported in bug# 317676, attempts to cache and reuse the original result from the stat call in KDirListerCache::slotFileDirty. Since that stat call is only needed to determine whether the "dirty" resource is a file or directory, caching the result helps us avoid the potential for tons of KDE::stat calls. The stat will happen if you for example copy or download a large file into a local folder while that folder is being viewed in a file browsing app such as dolphin or konqueror. The cached information is removed if the resource being monitored is deleted or renamed.

This addresses bug 317676.

Diffs (updated)

  kio/kio/kdirlister.cpp a721673 



The patch was tested by the bug reporter and it fixed the issue for him.


Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list