Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110834/
-----------------------------------------------------------

(Updated June 7, 2013, 5:03 a.m.)


Review request for kdelibs and David Faure.


Changes
-------

- Added code to remove items from the itemsInUseType cache when we navigate away.
- Added isLocalFile check to the code that removes items from the cache in slotFileRenamed.
- Renamed cachedItemsType to itemsInUseType
- Renamed CachedItemType to ItemType


Description
-------

This patch, inspired by the issue reported in bug# 317676, attempts to cache and reuse the original result from the stat call in KDirListerCache::slotFileDirty. Since that stat call is only needed to determine whether the "dirty" resource is a file or directory, caching the result helps us avoid the potential for tons of KDE::stat calls. The stat will happen if you for example copy or download a large file into a local folder while that folder is being viewed in a file browsing app such as dolphin or konqueror. The cached information is removed if the resource being monitored is deleted or renamed.


This addresses bug 317676.
    http://bugs.kde.org/show_bug.cgi?id=317676


Diffs (updated)
-----

  kio/kio/kdirlister.cpp a721673 
  kio/kio/kdirlister_p.h a78cc3c 

Diff: http://git.reviewboard.kde.org/r/110834/diff/


Testing
-------

The patch was tested by the bug reporter and it fixed the issue for him.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130607/46830878/attachment.htm>