Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

Michel Ludwig michel.ludwig at gmail.com
Thu Jun 6 19:22:39 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109246/
-----------------------------------------------------------

(Updated June 6, 2013, 6:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs.


Description
-------

Absolute paths can, for example, have the form "E:/MyDocuments/test/test.tex" on Windows. Currently, KUrl::_relativePath assumes that 
"E:/MyDocuments/test/test.tex" is a relative path and

  KUrl::relativePath("E:/MyDocuments/", "E:/MyDocuments/test/test.tex") 

will therefore return "E:/MyDocuments/test/test.tex" instead of "test/test.tex". The attached patch fixes this issue.


Diffs
-----

  kdecore/io/kurl.cpp ef2ba12 

Diff: http://git.reviewboard.kde.org/r/109246/diff/


Testing
-------


Thanks,

Michel Ludwig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130606/f5fe06a1/attachment.htm>


More information about the kde-core-devel mailing list