Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.
Jekyll Wu
adaptee at gmail.com
Wed Jun 5 11:05:24 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110687/
-----------------------------------------------------------
(Updated June 5, 2013, 10:05 a.m.)
Review request for KDE Runtime and George Kiagiadakis.
Changes
-------
Fix spelling and grammer errors
Description
-------
As I have said in https://bugs.kde.org/show_bug.cgi?id=315073#c3 , Bugzilla's new and nice behavior (since 4.2.5) of rejecting reports against disabled versions brings a new usability problem to DrKonqi: users spend value time in downloading debug symbols, generating the backtrace, writing all information he/she can recall, but in the end only to find an error dialog telling them (in a not so clear and friendly way) that bugs.kde.org won't accept his/her report.
I would propose making version checking the very first step in the reporting assistant: a perfect bug report against an outdated version is still useless.
The patch has been created for sometime and works, but unfortunately I don't have much time for coding since then, so it is not as good as what I have planned to make it to be. Nevertheless, I think it is still a good improvement of the current situation.
This addresses bug 315073.
http://bugs.kde.org/show_bug.cgi?id=315073
Diffs (updated)
-----
drkonqi/CMakeLists.txt 39833d7
drkonqi/drkonqi_globals.h d5f098a
drkonqi/productmapping.h f926c9d
drkonqi/productmapping.cpp f4e59e5
drkonqi/reportassistantdialog.cpp c296059
drkonqi/reportassistantpages_bugzilla_versioncheck.h PRE-CREATION
drkonqi/reportassistantpages_bugzilla_versioncheck.cpp PRE-CREATION
drkonqi/reportinterface.h c7e374e
drkonqi/reportinterface.cpp 4190c40
drkonqi/ui/assistantpage_versioncheck.ui PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110687/diff/
Testing
-------
File Attachments
----------------
rejecting disabled version
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/28/drkonqi-version-checking.png
reject disabled versions (revised edition)
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/30/bugzilla-version-cheking-improved.png
Thanks,
Jekyll Wu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130605/d809305b/attachment.htm>
More information about the kde-core-devel
mailing list