Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

Dawit Alemayehu adawit at kde.org
Wed Jun 5 06:46:03 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110834/
-----------------------------------------------------------

Review request for kdelibs and David Faure.


Description
-------

This patch, inspired by the issue reported in bug# 317676, attempts to stop a litany of the ::stat sys call that occur everytime KDirListerCache::slotFileDirty. These stat calls serve no other purpose than to determine whether the "dirty" resource is a file or directory. As such by caching the original stat and reusing the result, we can avoid tons of stat calls when a large file/directory is either copied or downloaded while the destination folder is opened in a file browser.


This addresses bug 317676.
    http://bugs.kde.org/show_bug.cgi?id=317676


Diffs
-----

  kio/kio/kdirlister.cpp a721673 
  kio/kio/kdirlister_p.h a78cc3c 

Diff: http://git.reviewboard.kde.org/r/110834/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130605/8fd7c570/attachment.htm>


More information about the kde-core-devel mailing list