Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

Dawit Alemayehu adawit at
Wed Jun 5 06:46:03 BST 2013

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and David Faure.


This patch, inspired by the issue reported in bug# 317676, attempts to stop a litany of the ::stat sys call that occur everytime KDirListerCache::slotFileDirty. These stat calls serve no other purpose than to determine whether the "dirty" resource is a file or directory. As such by caching the original stat and reusing the result, we can avoid tons of stat calls when a large file/directory is either copied or downloaded while the destination folder is opened in a file browser.

This addresses bug 317676.


  kio/kio/kdirlister.cpp a721673 
  kio/kio/kdirlister_p.h a78cc3c 




Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list