Review Request 110824: Make desktop grid only consider windows from current activity

[Stefanos Harhalakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110824/
-----------------------------------------------------------

(Updated June 4, 2013, 9:59 p.m.)


Review request for kde-workspace.


Changes
-------

I was not sure about the 'present windows' case (line 890) so I didn't touch it before. The current patch version should be ok.

I believe that the stacking order is needed to make sure that the top-most window is selected when there's overlap and should stay as-is.

Regarding the iteration method, the only reason to keep that would be to use foreach() but I don't see a point in that. In any case, that should be a different change. Right?


Description
-------

Fix windowAt function to only return windows from current activity.


This addresses bug 301447.
    http://bugs.kde.org/show_bug.cgi?id=301447


Diffs (updated)
-----

  kwin/effects/desktopgrid/desktopgrid.cpp dc3d82b 

Diff: http://git.reviewboard.kde.org/r/110824/diff/


Testing
-------


Thanks,

Stefanos Harhalakis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130604/b8e65a4c/attachment.htm>