Review Request 110824: Make desktop grid only consider windows from current activity

Stefanos Harhalakis v13 at
Tue Jun 4 22:59:39 BST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated June 4, 2013, 9:59 p.m.)

Review request for kde-workspace.


I was not sure about the 'present windows' case (line 890) so I didn't touch it before. The current patch version should be ok.

I believe that the stacking order is needed to make sure that the top-most window is selected when there's overlap and should stay as-is.

Regarding the iteration method, the only reason to keep that would be to use foreach() but I don't see a point in that. In any case, that should be a different change. Right?


Fix windowAt function to only return windows from current activity.

This addresses bug 301447.

Diffs (updated)

  kwin/effects/desktopgrid/desktopgrid.cpp dc3d82b 




Stefanos Harhalakis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list