Review Request 110799: Remove translation via babelfish - service is no longer avaibable - use google as default

[Burkhard Lück]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110799/
-----------------------------------------------------------

Review request for KDE Base Apps and David Faure.


Description
-------

Since may 2012 the babelfish service is no longer available, it was moved to Bing translator
and can't be used no more.
I changed default translator to Google, which is already used by kdepim/pimcommon/translator/

Translating a selection did not work with the old code, so I used the code 
from Laurent Montel in the pim translator.

Btw. pimcommon lib has a nice translation bar, could probably be reused here.


Diffs
-----

  konq-plugins/babelfish/plugin_babelfish.cpp c962f18 
  konq-plugins/babelfish/plugin_babelfish.desktop 267ac60 

Diff: http://git.reviewboard.kde.org/r/110799/diff/


Testing
-------

Tested in master + 4.10 in HTML + WebKit view modes

Result is the same as using translate.google.com direct with text or an url.

In master in HTML mode a JavaScript Error Warning pops up:
"An error occurred while attempting to run a script on this page.
....
Type-Error: Attempt to use a non-function object or a value as a function."


Thanks,

Burkhard Lück

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130603/995c1875/attachment.htm>