Review Request 111462: Avoid unnecessary stat of destination directory during copy/move in KDirWatch

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111462/#review36335
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On July 23, 2013, 3:47 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111462/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 3:47 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> The patch has been modified to only avoid unnecessary stat of the destination directory during copy/move operations in KDirWatch. This way when copying a file A to directory B does not result in directory B being stat'ed everytime file A changes.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kdirwatch.cpp a325f0f 
> 
> Diff: http://git.reviewboard.kde.org/r/111462/diff/
> 
> 
> Testing
> -------
> 
> - strace an instance of Konqueror or Dolphin.
> - copy a file from a remote location (ftp,sftp, smb) to your local file system.
> - check if there is a flood of stat calls on both the file being copied and its destination directory.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130723/24c774ea/attachment.htm>