Review Request 111480: Notifications are shown multiple times

Kai Uwe Broulik kde at privat.broulik.de
Mon Jul 22 20:20:29 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111480/#review36320
-----------------------------------------------------------


This breaks Amarok's "Show OSD" shortcut where you could tell it to show the currently played track again.
Imho this should somehow be fixed in Amarok, it is the only app I know that has this issue.

- Kai Uwe Broulik


On July 16, 2013, 12:01 p.m., Cedric Bellegarde wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111480/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 12:01 p.m.)
> 
> 
> Review request for kde-workspace and Marco Martin.
> 
> 
> Description
> -------
> 
> Do not replace notifications with same summary and body 
> 
> Here a patch similar to this colibri commit.
> 
> See REVIEW: 110745
> http://quickgit.kde.org/?p=colibri.git&a=commit&h=9a96b9512579215bcddd8fc88041fdd7130dbb0f
> 
> 
> This addresses bug 313440.
>     http://bugs.kde.org/show_bug.cgi?id=313440
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/Notifications.qml ce3f8de 
> 
> Diff: http://git.reviewboard.kde.org/r/111480/diff/
> 
> 
> Testing
> -------
> 
> Working here
> 
> 
> Thanks,
> 
> Cedric Bellegarde
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130722/2391431e/attachment.htm>


More information about the kde-core-devel mailing list