Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111585/#review36198
-----------------------------------------------------------


Thanks for the unittest; I don't see the added documentation though?


kio/kio/updateclipboard.cpp
<http://git.reviewboard.kde.org/r/111585/#comment26795>

    My comment (Q_ASSERT, otherwise memory leak) still stands.



kio/tests/fileundomanagertest.h
<http://git.reviewboard.kde.org/r/111585/#comment26798>

    add bug number as comment, like 2 lines above



kio/tests/fileundomanagertest.cpp
<http://git.reviewboard.kde.org/r/111585/#comment26796>

    I'd use qobject_cast and a QVERIFY, to catch a possible problem with the wrong job type being returned.



kio/tests/fileundomanagertest.cpp
<http://git.reviewboard.kde.org/r/111585/#comment26797>

    Try with QVERIFY(job->exec()), while you're here. synchronousRun is older and should be deprecated at some point, I think.


- David Faure


On July 19, 2013, 11:56 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111585/
> -----------------------------------------------------------
> 
> (Updated July 19, 2013, 11:56 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch fixes a bug where the contents of the clipboard are prematurely updated during a cut and paste operation. In the process I also discovered that undoing the operation does not update the clipboard either. Hence that too is fixed by this patch.
> 
> Please note that this patch does not address all the cases where the content of the clipboard is not updated after a KIO operation. More specifically the clipboard content will be out of sync if the user performs the following operations:
> 
> - copy/cut a file or a directory and rename it
> - copy/cut a file or a directory and move it
> - copy/cut a file or a directory and delete it.
> 
> In fact there is a ticket for the copy/cut and rename file/directory scenario (bug# 134960). However, addressing these issues require a careful consideration of how to do it since delete/rename/move operations can be done outside of KDE's control. Do we simply fix the KIO jobs to handle this or do we address it the KDirWatch level so we catch all the scenarios? Probably the latter. Anyhow, that can wait until for the 134960 fix.
> 
> 
> This addresses bug 318757.
>     http://bugs.kde.org/show_bug.cgi?id=318757
> 
> 
> Diffs
> -----
> 
>   kio/CMakeLists.txt f7a3767 
>   kio/kio/fileundomanager.cpp 9f76fef 
>   kio/kio/paste.cpp ca451fb 
>   kio/kio/updateclipboard.cpp PRE-CREATION 
>   kio/kio/updateclipboard_p.h PRE-CREATION 
>   kio/tests/fileundomanagertest.h ebd02fa 
>   kio/tests/fileundomanagertest.cpp 7c1352c 
> 
> Diff: http://git.reviewboard.kde.org/r/111585/diff/
> 
> 
> Testing
> -------
> 
> Unit and manual tests.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130720/d59c0133/attachment.htm>