Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
-----------------------------------------------------------

(Updated July 11, 2013, 11:37 p.m.)


Review request for kdelibs.


Changes
-------

Made first iteration of the changes as discussed.

I am not entirely sure whether or not SimpleJob::requestMessageBox and JobUiDelegate::requestMessageBox should be more generic or very specific with many parameters as I have them now.


Description
-------

The attached patch addresses one of the oldest bugs in KIO. Due to the muti-process nature of KIO, if any of the ioslaves encounter something that requires user input, the user might end up getting prompted multiple times. The best example of this is SSL error warnings sent to the client by kio_http. The patch completely resolves this problem using the same approach as kpasswdserver, but without the need for an additional kded process.


This addresses bugs 154100 and 265228.
    http://bugs.kde.org/show_bug.cgi?id=154100
    http://bugs.kde.org/show_bug.cgi?id=265228


Diffs (updated)
-----

  kio/CMakeLists.txt 4854829 
  kio/kio/job.cpp 096a7d7 
  kio/kio/jobclasses.h d771cfe 
  kio/kio/jobuidelegate.h 25e0728 
  kio/kio/jobuidelegate.cpp 85679c2 
  kio/kio/slaveinterface.h 4bfcec8 
  kio/kio/slaveinterface.cpp aa0fc44 
  kio/kio/slaveinterface_p.h e31ec5e 
  kio/kio/usernotificationhandler.cpp PRE-CREATION 
  kio/kio/usernotificationhandler_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111335/diff/


Testing
-------

Visit a site that throws up SSL warnings and causes KIO to show more than one error dialog.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130711/cd6d30d8/attachment.htm>