Review Request 111419: Use case-insensitive URL scheme comparisons in KUrl::isLocalFile

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111419/#review35674
-----------------------------------------------------------

Ship it!


OK. scheme() returns lowercase in Qt5 (which fixes this too), so I'll revert this after merging to frameworks.

- David Faure


On July 6, 2013, 4:55 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111419/
> -----------------------------------------------------------
> 
> (Updated July 6, 2013, 4:55 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> This patch fixes KUrl::isLocalFile to properly deal with upper case URL scheme.
> 
> 
> This addresses bug 295371.
>     http://bugs.kde.org/show_bug.cgi?id=295371
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kurl.cpp 5ea3e01 
>   kdecore/tests/kurltest.cpp 71770ee 
> 
> Diff: http://git.reviewboard.kde.org/r/111419/diff/
> 
> 
> Testing
> -------
> 
> kioclient exec "FILE:///"
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130707/2a90224d/attachment.htm>