Review Request 111402: make systemsettings use KDE_VERSION_STRING as its version string instead of the never changing "1.0"

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111402/#review35639
-----------------------------------------------------------


Yep, I am very much in favour of automatic versioning with KDE_VERSION_STRING in kde4 apps, makes things clear and easy.
Some people complain that it propagates the *kdelibs* version number to the app, which could be different (e.g. if you compile systemsettings from 4.10 with kdelibs from 4.9 or 4.11).
But still, it's better than the useless "1.0", that's for sure :)

- David Faure


On July 5, 2013, 2:59 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111402/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 2:59 p.m.)
> 
> 
> Review request for kde-workspace and Ben Cooksley.
> 
> 
> Description
> -------
> 
> The aim is that in the future we can disable outdated versions in the systemsettings product so that bugs.kde.org will reject crash reports from outdated versions.
> 
> I know systemsettings itself hasn't really changed much between releases. But since systemsettings is the main container of various KCMs (another one is kcmshell4),  and the crashes caused by those KCMs are reflected as crashes of systemsettings,  it becomes necessary for systemsetings to use a version scheme which can be used to identify different releases. The current never changing '1.0' version doesn't suit that need. 
> 
> Also see my similar requests against plasma-desktop[1] and dolphin[2].
> 
> [1] https://git.reviewboard.kde.org/r/109906/
> [2] http://lists.kde.org/?l=kfm-devel&m=137120231924936&w=2
> 
> 
> Diffs
> -----
> 
>   systemsettings/app/main.cpp 1656179 
> 
> Diff: http://git.reviewboard.kde.org/r/111402/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130705/23edc02d/attachment.htm>