Review Request 111390: kshorturifilter: inverted condition in home directory handling

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111390/
-----------------------------------------------------------

(Updated July 4, 2013, 6:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Runtime.


Description
-------

While investigating URI filtering/validation elsewhere I spotted some odd logic here.  The original line in question seems to be saying:

if (user is valid && user's home directory is empty)
{
  // replace from '~' onwards with home directory
}
else
{
  // generate an error
}

The second condition, though, is surely wrong.  It should say:

if (user is valid && user's home directory is NOT empty)
...


Diffs
-----

  kurifilter-plugins/shorturi/kshorturifilter.cpp d27b018 

Diff: http://git.reviewboard.kde.org/r/111390/diff/


Testing
-------

Build kderumtime with this change.  Checked correct results for '~' and '~user', where the user both exists and does not, in konqueror and krunner.  Ran the kurifiltertest with all passes.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130704/a820ffb8/attachment.htm>